[PATCH] D47076: [InstCombine] choose 1 form of abs and nabs as canonical

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 12:29:35 PDT 2018


efriedma added a comment.

I guess it doesn't really matter what form you choose as canonical, given the backend will pattern-match it anyway, but "x > 0" seems like a weird choice; it can't be lowered to a sign-bit check like "x < 0".


https://reviews.llvm.org/D47076





More information about the llvm-commits mailing list