[PATCH] D47005: [WebAssembly] Add MachineBasicBlock::isEHScopeEntry & setIsEHScopeEntry

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: include/llvm/CodeGen/MachineBasicBlock.h:387
+
   /// Returns true if this is the entry block of an EH funclet.
   bool isEHFuncletEntry() const { return IsEHFuncletEntry; }
----------------
aheejin wrote:
> dschuff wrote:
> > Is this comment the right place to note the difference between and EH scope and EH funclet in the IR? Is an EH funclet just a scope that will become outlined?
> Not sure what you mean..? Yes, a funclet is a scope that will be outlined. So these two are not exclusive; `isEHFuncletEntry` will be a subset of `isEHScopeEntry`. Do you mean I should elaborate more on the differences between the two here? 
Yeah, somewhere there should be a comment that says what the difference between an EH scope and an EH funclet, basically just what you said in your reply. I don't know if this is the place, but somewhere. It should also go in the commit message.


================
Comment at: lib/CodeGen/Analysis.cpp:679
   for (const MachineBasicBlock &MBB : MF) {
-    if (MBB.isEHFuncletEntry()) {
+    if (MBB.isEHScopeEntry()) {
       FuncletBlocks.push_back(&MBB);
----------------
If this code only cares about whether a block is in a scope (as opposed to a funclet), should the variable names and/or comments here be updated too?


Repository:
  rL LLVM

https://reviews.llvm.org/D47005