[PATCH] D47005: [WebAssembly] Add MachineBasicBlock::isEHScopeEntry & setIsEHScopeEntry

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 13:48:02 PDT 2018


aheejin added inline comments.


================
Comment at: include/llvm/CodeGen/MachineBasicBlock.h:387
+
   /// Returns true if this is the entry block of an EH funclet.
   bool isEHFuncletEntry() const { return IsEHFuncletEntry; }
----------------
dschuff wrote:
> Is this comment the right place to note the difference between and EH scope and EH funclet in the IR? Is an EH funclet just a scope that will become outlined?
Not sure what you mean..? Yes, a funclet is a scope that will be outlined. So these two are not exclusive; `isEHFuncletEntry` will be a subset of `isEHScopeEntry`. Do you mean I should elaborate more on the differences between the two here? 


Repository:
  rL LLVM

https://reviews.llvm.org/D47005





More information about the llvm-commits mailing list