[PATCH] D46977: [NFC] WebAssembly build fix
JF Bastien via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 16 15:26:02 PDT 2018
jfb added a comment.
In https://reviews.llvm.org/D46977#1102107, @sbc100 wrote:
> Thanks. Makes sense.
>
> My rational with the original change is that anyone who depends on libObject is almost certainly also depending on libBinaryFormat (at the very least the headers). But your change makes thing nicer since it allows some users to avoid the explicit dependency on the lib I guess.
Also: compile-time. Anything I don't intend to get inlined I'd rather have in .cpp files.
Repository:
rL LLVM
https://reviews.llvm.org/D46977
More information about the llvm-commits
mailing list