[PATCH] D46977: [NFC] WebAssembly build fix

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 15:25:46 PDT 2018


vsk added a comment.

I still see a build break with LLVM_ENABLE_MODULES=On:

  $ ninja DebugInfoCodeViewTests llvm-rc       
  [1/2] Linking CXX executable bin/llvm-rc
  FAILED: bin/llvm-rc 
  : && /Volumes/Xcode10A177_m18A288_i16A283_t16J278_w16R278a_b16P290a_XcodeInternals_32bitSupport_FastSim_Boost_ASan_36GB/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -fmodules -fmodules-cache-path=/Users/vsk/src/builds/llvm.org-master-RA/module.cache -fcxx-modules -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -O3 -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-dead_strip tools/llvm-rc/CMakeFiles/llvm-rc.dir/llvm-rc.cpp.o tools/llvm-rc/CMakeFiles/llvm-rc.dir/ResourceFileWriter.cpp.o tools/llvm-rc/CMakeFiles/llvm-rc.dir/ResourceScriptCppFilter.cpp.o tools/llvm-rc/CMakeFiles/llvm-rc.dir/ResourceScriptParser.cpp.o tools/llvm-rc/CMakeFiles/llvm-rc.dir/ResourceScriptStmt.cpp.o tools/llvm-rc/CMakeFiles/llvm-rc.dir/ResourceScriptToken.cpp.o  -o bin/llvm-rc  -Wl,-rpath, at loader_path/../lib lib/libLLVMOption.a lib/libLLVMSupport.a lib/libLLVMBinaryFormat.a lib/libLLVMSupport.a -lz -lcurses -lm lib/libLLVMDemangle.a && :
  Undefined symbols for architecture x86_64:
    "llvm::object::WasmSymbol::print(llvm::raw_ostream&) const", referenced from:
        llvm::object::WasmSymbol::dump() const in ResourceFileWriter.cpp.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  [2/2] Linking CXX executable unittests/DebugInfo/CodeView/DebugInfoCodeViewTests
  FAILED: unittests/DebugInfo/CodeView/DebugInfoCodeViewTests 
  : && /Volumes/Xcode10A177_m18A288_i16A283_t16J278_w16R278a_b16P290a_XcodeInternals_32bitSupport_FastSim_Boost_ASan_36GB/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -fmodules -fmodules-cache-path=/Users/vsk/src/builds/llvm.org-master-RA/module.cache -fcxx-modules -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -O3 -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-dead_strip unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/RandomAccessVisitorTest.cpp.o unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/TypeHashingTest.cpp.o unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/TypeIndexDiscoveryTest.cpp.o  -o unittests/DebugInfo/CodeView/DebugInfoCodeViewTests  lib/libLLVMDebugInfoCodeView.a lib/libLLVMBinaryFormat.a lib/libLLVMSupport.a lib/libgtest_main.a lib/libgtest.a lib/libLLVMTestingSupport.a lib/libLLVMDebugInfoMSF.a lib/libgtest.a lib/libLLVMSupport.a -lz -lcurses -lm lib/libLLVMDemangle.a -lpthread && :
  Undefined symbols for architecture x86_64:
    "llvm::object::WasmSymbol::print(llvm::raw_ostream&) const", referenced from:
        llvm::object::WasmSymbol::dump() const in RandomAccessVisitorTest.cpp.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

Do we need to make these targets depend on libObject?


Repository:
  rL LLVM

https://reviews.llvm.org/D46977





More information about the llvm-commits mailing list