[PATCH] D46875: [llvm-rc] Add support for the optional CLASS statement for dialogs

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: tools/llvm-rc/ResourceScriptParser.cpp:788
+RCParser::ParseOptionType RCParser::parseClassStmt() {
+  ASSIGN_OR_RETURN(Arg, readString());
+  return llvm::make_unique<ClassStmt>(*Arg);
----------------
amccarth wrote:
> The documentation is ambiguous and it's been a while since I've done this.  The class can be a string, but it can also be an unsigned integer.  Are those both parsed as quoted strings?  Are you choosing to just handle the string case for now?
You're right, this should probably be an IntOrString, will update.


Repository:
  rL LLVM

https://reviews.llvm.org/D46875