[PATCH] D46875: [llvm-rc] Add support for the optional CLASS statement for dialogs
Adrian McCarthy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 15 08:58:00 PDT 2018
amccarth added inline comments.
================
Comment at: tools/llvm-rc/ResourceScriptParser.cpp:788
+RCParser::ParseOptionType RCParser::parseClassStmt() {
+ ASSIGN_OR_RETURN(Arg, readString());
+ return llvm::make_unique<ClassStmt>(*Arg);
----------------
The documentation is ambiguous and it's been a while since I've done this. The class can be a string, but it can also be an unsigned integer. Are those both parsed as quoted strings? Are you choosing to just handle the string case for now?
Repository:
rL LLVM
https://reviews.llvm.org/D46875
More information about the llvm-commits
mailing list