[PATCH] D46243: Move Schedule class to header file for allowing inheritance

[Atheel Massalha via Phabricator via llvm-commits]

atheel.ma added a comment.

Hi again.
as I see now that passing ScheduleDAGMI instead of ScheduleDAG is not a good idea,
I think ScheduleDAG is better becuase we dont want to force the user to use the implementation of the opensource (ScheduleDAGMI),
if we pass ScheduleDAG then the user can inherit from ScheduleDAG and make his own pass, but if we change it to ScheduleDAGMI (which is declared and implemented in an open source *CPP* file - meant cant inherit from it, then the user will be stuck with this implemntations of ScheduleDAGMI...

so I guess I will need to use static cast (unfortunately...)

if you have another suggestion I will be happy so hear about.

thanks


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46243