[PATCH] D46243: Move Schedule class to header file for allowing inheritance

[Andrew Trick via Phabricator via llvm-commits]

atrick added a comment.

In https://reviews.llvm.org/D46243#1089608, @atheel.ma wrote:

> Hi Andy,
>
> thanks for your suggestion and remarks.
>  I think passing DAGMI(ScheduleDAGInstrs) instead of DAG can be the first step for my solution, then I will also need to add some functions to the interface of AliasAnalisys (some generic functions like getDistanceBetweenMemorys(MIa,MIb)...). I hope this will be accepted.
>
> but the problem is that AliasAnalysis *AAForDep; is 'protected' inside the DAGI, do you think its acceptable to add getAA() to the interface of the DAGMI ?
>
> thanks,
> Atheel


Adding getAA() seems harmless since it could just return nullptr for any target that doesn't use AA. You could assert that it's nonnull for your target.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46243