[PATCH] D46653: Start support for linking object files with split stacks

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D46653#1094768, @ruiu wrote:

> If you have other patches in the series, could you also send it for review? It would be easier for me to review individual patch once I get a whole idea about how you are going to support -fsplit-stack.


+1. Please let us see the whole implementation plan.



================
Comment at: ELF/InputFiles.cpp:649
+  // the no_split_stack attribute, then the object file will also have
+  // a .note.GNU-no-split-stack section."
   if (Name == ".note.GNU-split-stack") {
----------------
I'm not an expert in licenses. I do not know if we can quote the text like that. It probably belongs to a different code license. I think we usually write own comments and just add a link if we need. Can you do the same here?


================
Comment at: ELF/InputFiles.cpp:655-656
     return &InputSection::Discarded;
+  } else {
+    if (Name == ".note.GNU-no-split-stack") {
+      this->SomeNoSplitStack = true;
----------------
ruiu wrote:
> `else { if` -> `else if`
No need to do 'else' at all, the first branch ends with the `return`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46653