[PATCH] D46653: Start support for linking object files with split stacks

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

If you have other patches in the series, could you also send it for review? It would be easier for me to review individual patch once I get a whole idea about how you are going to support -fsplit-stack.



================
Comment at: ELF/InputFiles.cpp:644
+  // commonly used in the programming languages Go and Rust.  For the
+  // details, see // https://gcc.gnu.org/wiki/SplitStacks.  "...each
+  // object file compiled in split stack mode will have an empty
----------------
remove //


================
Comment at: ELF/InputFiles.cpp:655-656
     return &InputSection::Discarded;
+  } else {
+    if (Name == ".note.GNU-no-split-stack") {
+      this->SomeNoSplitStack = true;
----------------
`else { if` -> `else if`


================
Comment at: ELF/InputFiles.h:210-211
 
+  // Compilers set both of these per object file, although it would be
+  // more convenient if they did it per section, or even per symbol.
+  // True if the file defines functions compiled with
----------------
I'd think you don't need to add this comment because that's true to some other members too.


================
Comment at: ELF/InputFiles.h:215
+  bool SplitStack = false;
+  // True if the file defines functions compiled with -fsplit-stack,
+  // but had one or more functions with the no_split_stack attribute.
----------------
nit: add a blank line just like the above.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46653