[PATCH] D46723: Require GCC 5.0 and LLVM 3.4 at a minimum

[Eric Christopher via llvm-commits]

LGTM

On Thu, May 10, 2018, 1:25 PM JF Bastien via Phabricator <
reviews at reviews.llvm.org> wrote:

> jfb created this revision.
> Herald added subscribers: aheejin, mgorny.
>
> As discussed in:
> http://lists.llvm.org/pipermail/llvm-dev/2018-May/123182.html
>
> Let's start migrating to C++14. As a first step, update the GCC and LLVM
> versions to the ones that first got full C++14 support, and see if bots
> fall
> over and die. If that sticks, let's then update the rest of this file
> (MSVC and
> standard libraries). If it all works out (let's be honest: it won't for a
> while)
> then we can bump to -std=c++14.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D46723
>
> Files:
>   cmake/modules/CheckCompilerVersion.cmake
>
>
> Index: cmake/modules/CheckCompilerVersion.cmake
> ===================================================================
> --- cmake/modules/CheckCompilerVersion.cmake
> +++ cmake/modules/CheckCompilerVersion.cmake
> @@ -1,19 +1,19 @@
> -# Check if the host compiler is new enough. LLVM requires at least GCC
> 4.8,
> -# MSVC 2015 (Update 3), or Clang 3.1.
> +# Check if the host compiler is new enough. LLVM requires at least GCC
> 5.0,
> +# MSVC 2015 (Update 3), or Clang 3.4.
>
>  include(CheckCXXSourceCompiles)
>
>  if(NOT DEFINED LLVM_COMPILER_CHECKED)
>    set(LLVM_COMPILER_CHECKED ON)
>
>    if(NOT LLVM_FORCE_USE_OLD_TOOLCHAIN)
>      if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
> -      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)
> -        message(FATAL_ERROR "Host GCC version must be at least 4.8!")
> +      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)
> +        message(FATAL_ERROR "Host GCC version must be at least 5.0!")
>        endif()
>      elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
> -      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.1)
> -        message(FATAL_ERROR "Host Clang version must be at least 3.1!")
> +      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.4)
> +        message(FATAL_ERROR "Host Clang version must be at least 3.4!")
>        endif()
>
>        if (CMAKE_CXX_SIMULATE_ID MATCHES "MSVC")
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180510/da8e6ac5/attachment.html>