[PATCH] D46723: Require GCC 5.0 and LLVM 3.4 at a minimum

[JF Bastien via Phabricator via llvm-commits]

jfb added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:15-16
     elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.1)
-        message(FATAL_ERROR "Host Clang version must be at least 3.1!")
+      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.4)
+        message(FATAL_ERROR "Host Clang version must be at least 3.4!")
       endif()
----------------
lebedev.ri wrote:
> I think you want clang 3.5+
> https://godbolt.org/g/yq25fe
I'm not sure: according to http://en.cppreference.com/w/cpp/compiler_support#cpp14 we're OK with 3.4. It's OK to use c++1y for 3.4 if it has all of C++14 and isn't buggy.


Repository:
  rL LLVM

https://reviews.llvm.org/D46723