[llvm] r331983 - [DWARF] dwarfgen::LineTable::writeData(): pacify -Wcovered-switch-default

[James Henderson via llvm-commits]

Hi,

Thanks for this and the other fixes! You beat me to them. I also have a
potential fix for the crashing tests pending (I don't have access to a PPC
build, so I can't be certain that they will). I'll be committing it shortly.

James

On 10 May 2018 at 15:16, Roman Lebedev via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: lebedevri
> Date: Thu May 10 07:16:41 2018
> New Revision: 331983
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331983&view=rev
> Log:
> [DWARF] dwarfgen::LineTable::writeData(): pacify -Wcovered-switch-default
>
> Modified:
>     llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp
>
> Modified: llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/
> DebugInfo/DWARF/DwarfGenerator.cpp?rev=331983&
> r1=331982&r2=331983&view=diff
> ============================================================
> ==================
> --- llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp (original)
> +++ llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp Thu May 10
> 07:16:41 2018
> @@ -203,16 +203,15 @@ void dwarfgen::LineTable::writeData(Arra
>      case Long:
>      case Quad:
>        Asm.OutStreamer->EmitIntValue(Entry.Value, Entry.Length);
> -      break;
> +      continue;
>      case ULEB:
>        Asm.EmitULEB128(Entry.Value);
> -      break;
> +      continue;
>      case SLEB:
>        Asm.EmitSLEB128(Entry.Value);
> -      break;
> -    default:
> -      llvm_unreachable("unsupported ValueAndLength Length value");
> +      continue;
>      }
> +    llvm_unreachable("unsupported ValueAndLength Length value");
>    }
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180510/13e4178b/attachment.html>