<div dir="ltr"><div><div>Hi,<br><br></div>Thanks for this and the other fixes! You beat me to them. I also have a potential fix for the crashing tests pending (I don't have access to a PPC build, so I can't be certain that they will). I'll be committing it shortly.<br><br></div>James<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 10 May 2018 at 15:16, Roman Lebedev via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lebedevri<br>
Date: Thu May 10 07:16:41 2018<br>
New Revision: 331983<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=331983&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=331983&view=rev</a><br>
Log:<br>
[DWARF] dwarfgen::LineTable::<wbr>writeData(): pacify -Wcovered-switch-default<br>
<br>
Modified:<br>
    llvm/trunk/unittests/<wbr>DebugInfo/DWARF/<wbr>DwarfGenerator.cpp<br>
<br>
Modified: llvm/trunk/unittests/<wbr>DebugInfo/DWARF/<wbr>DwarfGenerator.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp?rev=331983&r1=331982&r2=331983&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/unittests/<wbr>DebugInfo/DWARF/<wbr>DwarfGenerator.cpp?rev=331983&<wbr>r1=331982&r2=331983&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/unittests/<wbr>DebugInfo/DWARF/<wbr>DwarfGenerator.cpp (original)<br>
+++ llvm/trunk/unittests/<wbr>DebugInfo/DWARF/<wbr>DwarfGenerator.cpp Thu May 10 07:16:41 2018<br>
@@ -203,16 +203,15 @@ void dwarfgen::LineTable::<wbr>writeData(Arra<br>
     case Long:<br>
     case Quad:<br>
       Asm.OutStreamer->EmitIntValue(<wbr>Entry.Value, Entry.Length);<br>
-      break;<br>
+      continue;<br>
     case ULEB:<br>
       Asm.EmitULEB128(Entry.Value);<br>
-      break;<br>
+      continue;<br>
     case SLEB:<br>
       Asm.EmitSLEB128(Entry.Value);<br>
-      break;<br>
-    default:<br>
-      llvm_unreachable("unsupported ValueAndLength Length value");<br>
+      continue;<br>
     }<br>
+    llvm_unreachable("unsupported ValueAndLength Length value");<br>
   }<br>
 }<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>