[PATCH] D46690: [ELF] - Improve the test cases for notes sections.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D46690#1094388, @emaste wrote:

> note-noalloc2.s is close to my original test, I think that's reasonable.
>
> For the note-noalloc.s change we've lost the check that the non-alloc note still has a section. I think we should keep that.


See.

I am checking that PT_NOTE has a 16 bytes size (so that is including only "a" section).
I am not sure why do we want to check that we have a output section for non-a. Currently, we can have the following behavior of LLD:

1. If we have `note.x` and `note y`, where first is "a" and second is non-a. We will have 2 sections in the output.

2. we can have 2 `.note` sections, one of which is "a" and the second is non-a. LLD will combine them into single `.note` by name, I think.

And we will emit the PT_NOTE for both.

Your change changed how PT_NOTES are emitted., it did not change how we emit the output sections. 
So I would not add tests for output notes probably as 1+2 shows we have no special rules for notes right now I think.


https://reviews.llvm.org/D46690