[PATCH] D46690: [ELF] - Improve the test cases for notes sections.

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 05:48:31 PDT 2018


emaste accepted this revision.
emaste added a comment.
This revision is now accepted and ready to land.

note-noalloc2.s is close to my original test, I think that's reasonable.

For the note-noalloc.s change we've lost the check that the non-alloc note still has a section. I think we should keep that.



================
Comment at: test/ELF/note-noalloc.s:2
 // REQUIRES: x86
-// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-freebsd %s -o %t.o
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
 // RUN: ld.lld %t.o -o %t -shared
----------------
aww


https://reviews.llvm.org/D46690





More information about the llvm-commits mailing list