[PATCH] D46589: [llvm-objcopy] Add more tests for help messages

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 9 01:49:19 PDT 2018


jhenderson accepted this revision.
jhenderson added a comment.

LGTM with the suggested test update.



================
Comment at: help-message.test:12
 # CHECK-OBJCOPY: USAGE: llvm-objcopy
+# CHECK-OBJCOPY-UNKNOWN-ARGUMENT: unknown argument '-abcabc'
+# CHECK-OBJCOPY-NO-INPUT-FILES: No input file specified
----------------
This and the other messages (apart from the USAGE ones) don't need to have unique prefixes for objcopy and strip. I'd rewrite them something like this:

```
# OBJCOPY-USAGE: USAGE: llvm-objcopy
# STRIP-USAGE:   USAGE: llvm-strip
# UNKNOWN-ARG: unknown argument '-abcabc'
# NO-INPUT-FILES: No input file specified
```


Repository:
  rL LLVM

https://reviews.llvm.org/D46589





More information about the llvm-commits mailing list