[PATCH] D46589: [llvm-objcopy] Add more tests for help messages

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap created this revision.
alexshap added reviewers: jakehehrlich, jhenderson.

Slightly reorganize the tests + improve the coverage (for llvm-objcopy as well).
I'll wait for James to have a look at this.

Test plan: make check-all


Repository:
  rL LLVM

https://reviews.llvm.org/D46589

Files:
  help-message.test
  strip-debug.test


Index: strip-debug.test
===================================================================
--- strip-debug.test
+++ strip-debug.test
@@ -10,8 +10,6 @@
 # RUN: llvm-readobj -file-headers -sections -symbols %t3 | FileCheck %s
 # RUN: cmp %t2 %t3
 
-# RUN: not llvm-strip -strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
-
 !ELF
 FileHeader:
   Class:           ELFCLASS64
@@ -62,5 +60,3 @@
 # CHECK-NEXT:     Section: .text
 # CHECK-NEXT:   }
 # CHECK-NEXT: ]
-
-# NO-INPUT-FILES: No input file specified
Index: help-message.test
===================================================================
--- help-message.test
+++ help-message.test
@@ -1,8 +1,17 @@
 # RUN: llvm-objcopy --help | FileCheck --check-prefix=CHECK-OBJCOPY %s
 # RUN: not llvm-objcopy 2>&1 | FileCheck --check-prefix=CHECK-OBJCOPY %s
+# RUN: not llvm-objcopy -abcabc 2>&1 | FileCheck --check-prefix=CHECK-OBJCOPY-UNKNOWN-ARGUMENT %s
+# RUN: not llvm-objcopy -strip-debug 2>&1 | FileCheck %s --check-prefix=CHECK-OBJCOPY-NO-INPUT-FILES
 
 # RUN: llvm-strip --help | FileCheck --check-prefix=CHECK-STRIP %s
 # RUN: not llvm-strip 2>&1 | FileCheck --check-prefix=CHECK-STRIP %s
+# RUN: not llvm-strip -abcabc 2>&1 | FileCheck --check-prefix=CHECK-STRIP-UNKNOWN-ARGUMENT %s
+# RUN: not llvm-strip -strip-debug 2>&1 | FileCheck %s --check-prefix=CHECK-STRIP-NO-INPUT-FILES
 
 # CHECK-OBJCOPY: USAGE: llvm-objcopy
+# CHECK-OBJCOPY-UNKNOWN-ARGUMENT: unknown argument '-abcabc'
+# CHECK-OBJCOPY-NO-INPUT-FILES: No input file specified
+
 # CHECK-STRIP:   USAGE: llvm-strip
+# CHECK-STRIP-UNKNOWN-ARGUMENT: unknown argument '-abcabc'
+# CHECK-STRIP-NO-INPUT-FILES: No input file specified


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46589.145724.patch
Type: text/x-patch
Size: 1664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180508/a067ca18/attachment.bin>