[PATCH] D46567: [llvm-strip] Add support for -remove-section

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-and-remove.test:1
+# RUN: yaml2obj %s > %t
+# RUN: llvm-strip -remove-section=.text.bar %t
----------------
alexshap wrote:
> jakehehrlich wrote:
> > Why not just extend the existing --remove-section tests with llvm-strip?
> the existing tests 
> 
> alexshap-mbp:llvm-objcopy alexshap$ grep -n remove-section ./*
> 
> ./armexidx-link.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
> ./group-big-endian.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
> ./group-unchanged.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
> ./group.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
> 
> those tests verify something else and the inputs don't contain debug info.
> At the beginning i thought i would extend one of them, 
> but then it turned out to be less straightforward than I expected or I don't see the test you are referring to.
> 
> 
There are a few tests like remove-section.test that only use the -R short option. It might be better to extend those (and probably also test both short and long options to avoid this confusion).


Repository:
  rL LLVM

https://reviews.llvm.org/D46567