[PATCH] D46567: [llvm-strip] Add support for -remove-section

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 18:17:46 PDT 2018


alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-and-remove.test:1
+# RUN: yaml2obj %s > %t
+# RUN: llvm-strip -remove-section=.text.bar %t
----------------
jakehehrlich wrote:
> Why not just extend the existing --remove-section tests with llvm-strip?
the existing tests 

alexshap-mbp:llvm-objcopy alexshap$ grep -n remove-section ./*

./armexidx-link.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
./group-big-endian.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
./group-unchanged.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2
./group.test:2:# RUN: llvm-objcopy -remove-section=.text.bar %t %t2

those tests verify something else and the inputs don't contain debug info.
At the beginning i thought i would extend one of them, 
but then it turned out to be less straightforward than I expected or I don't see the test you are referring to.




Repository:
  rL LLVM

https://reviews.llvm.org/D46567





More information about the llvm-commits mailing list