[PATCH] D45848: [WebAssembly] Initial Disassembler.

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 15:49:03 PDT 2018


aardappel marked an inline comment as done.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp:139
+  for (uint8_t OPI = 0; OPI < WasmInst->NumOperands; OPI++) {
+    auto OT = WasmInst->Operands[OPI];
+    switch (OT) {
----------------
sbc100 wrote:
> At least to my eye this is overuse of auto, but i can't see what the type of OT is here.
> 
> See: https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
I'm an "maximally auto" kind of person so I may miss these on occasion :)


Repository:
  rL LLVM

https://reviews.llvm.org/D45848





More information about the llvm-commits mailing list