[PATCH] D45848: [WebAssembly] Initial Disassembler.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 7 15:37:32 PDT 2018
sbc100 added a comment.
I don't think there is a problem with landing a partial implementation. Up to you I guess.
I'm wondering if this change will be enough for me to use it in some of the existing tests where are force to use obj2yaml.
================
Comment at: lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp:139
+ for (uint8_t OPI = 0; OPI < WasmInst->NumOperands; OPI++) {
+ auto OT = WasmInst->Operands[OPI];
+ switch (OT) {
----------------
At least to my eye this is overuse of auto, but i can't see what the type of OT is here.
See: https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
Repository:
rL LLVM
https://reviews.llvm.org/D45848
More information about the llvm-commits
mailing list