[PATCH] D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC)

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: COFF/PDB.cpp:1075-1076
+    bool HasWS = Arg.find(' ') != StringRef::npos;
+    if (HasWS)
+      ArgStr.push_back('"');
+    ArgStr.append(Arg);
----------------
In addition to what rui suggested, can you only do this if the string is not already quoted?  Furthermore, you may need to escape embedded quotes (is that something we need to worry about?)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46427