[PATCH] D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/PDB.cpp:1068
+
+  // MSVC surrounds arguments containing spaces with quotes, so we do the same.
+  SmallString<256> ArgStr;
----------------
Can you factor this code as `std::string quote(ArayRef<StringRef>)`?

I believe you also need to quote a double-quote as double double-quotes as well (but please check what the MS linker behavior is first.)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46427