[PATCH] D46478: [Coverage] Do not skip functions with the same name when loading CoverageMapping.

[Max Moroz via Phabricator via llvm-commits]

Dor1s created this revision.
Dor1s added reviewers: vsk, morehouse.
Herald added a subscriber: llvm-commits.

That change makes it possible to generate code coverage reports from
different binaries compiled from different sources even if there are function
with non-unique names. Without that change, code coverage for such functions is
missing except of the first function processed.


Repository:
  rL LLVM

https://reviews.llvm.org/D46478

Files:
  lib/ProfileData/Coverage/CoverageMapping.cpp


Index: lib/ProfileData/Coverage/CoverageMapping.cpp
===================================================================
--- lib/ProfileData/Coverage/CoverageMapping.cpp
+++ lib/ProfileData/Coverage/CoverageMapping.cpp
@@ -207,10 +207,6 @@
   else
     OrigFuncName = getFuncNameWithoutPrefix(OrigFuncName, Record.Filenames[0]);
 
-  // Don't load records for functions we've already seen.
-  if (!FunctionNames.insert(OrigFuncName).second)
-    return Error::success();
-
   CounterMappingContext Ctx(Record.Expressions);
 
   std::vector<uint64_t> Counts;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46478.145298.patch
Type: text/x-patch
Size: 557 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180504/64d510b9/attachment.bin>