[PATCH] D46339: [GlobalISel][Legalizer] LegalizerInfo verifier: Follow Up

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 17:04:09 PDT 2018


rtereshin added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-2.mir:1
-# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
+# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1
+# XFAIL: *
----------------
qcolombet wrote:
> Should be converted into a `not llc` with a comment explaining why it is incorrect.
> (Already said it in the other review.)
What's the policy here to decide between `XFAIL` and `not llc` (or `not opt` etc)?


Repository:
  rL LLVM

https://reviews.llvm.org/D46339





More information about the llvm-commits mailing list