[PATCH] D46339: [GlobalISel][Legalizer] LegalizerInfo verifier: Follow Up

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: lib/Target/AArch64/AArch64LegalizerInfo.cpp:228
       })
-      .legalFor({s64, p0});
+      .legalFor({{p0, s64}});
 
----------------
Haha, nice!


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-2.mir:1
-# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
+# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1
+# XFAIL: *
----------------
Should be converted into a `not llc` with a comment explaining why it is incorrect.
(Already said it in the other review.)


Repository:
  rL LLVM

https://reviews.llvm.org/D46339