[PATCH] D45320: [MemDep] Fixed handling of invariant.group

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 07:55:14 PDT 2018


dberlin added inline comments.


================
Comment at: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:1472
+      if (entry.second.getAddress() == P.getPointer())
+        KeysToDelete.push_back(entry.first);
+    for (const auto *Key : KeysToDelete)
----------------
You may want to do compilation time measurements on this on some bigger cases, if you haven't.

This is likely to be painfully slow in some cases.


Repository:
  rL LLVM

https://reviews.llvm.org/D45320





More information about the llvm-commits mailing list