[PATCH] D45320: [MemDep] Fixed handling of invariant.group

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 07:52:28 PDT 2018


So, please don't let me stand in the way of reasonable fixes.  I only get
~20 minutes a day to look at llvm stuff these days unless i'm on vacation.
Maybe some day it'll be better again, but i suspect it'll be a while ;)

On Thu, May 3, 2018 at 4:25 AM, Krzysztof Pszeniczny via Phabricator <
reviews at reviews.llvm.org> wrote:

> amharc accepted this revision.
> amharc added a comment.
> This revision is now accepted and ready to land.
>
> I think it would be a little bit cleaner if the relevant checks were added
> to `verifyRemoved` too, where all other maps are traversed in debug builds.
> However, `AssertingVH` is probably a good enough guarantee ;)
>
> You probably want to wait for dberlin to accept this.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45320
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180503/f7198f4c/attachment.html>


More information about the llvm-commits mailing list