[PATCH] D46272: AMDGPU: Remove #include "MCTargetDesc/AMDGPUMCTargetDesc.h" from common headers

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

There are some unrelated changes, which I think should be mentioned in the commit description. Apart from that LGTM.



================
Comment at: lib/Target/AMDGPU/AMDGPURegisterInfo.cpp:17
 #include "AMDGPUTargetMachine.h"
+#include "SIMachineFunctionInfo.h"
 #include "SIRegisterInfo.h"
----------------
Why is this necessary? Shouldn't headers generally be self-contained (i.e. include all their dependencies)?


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:26
 #include "SIInstrInfo.h"
-#include "SIMachineFunctionInfo.h"
 #include "Utils/AMDGPUBaseInfo.h"
----------------
Ah I see. This seems like a separate change, although I wouldn't mind committing them together as long as the description is updated to reflect this.


Repository:
  rL LLVM

https://reviews.llvm.org/D46272