[llvm] r282872 - CVP. Turn marking adds as no wrap on by default (was turned off by 279082)

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 09:00:43 PDT 2018


Did any of this ever get resolved?
This code has been sitting around unused for over a year now.

(I was looking at CVP and trying to understand why it has an uncommented,
not-understandable parameter called "dontprocessadds")


On Thu, Feb 23, 2017 at 2:41 PM, Hans Wennborg via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> This was reverted in r296030 due to PR31181.
>
> On Fri, Sep 30, 2016 at 9:20 AM, Artur Pilipenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: apilipenko
> > Date: Fri Sep 30 11:20:08 2016
> > New Revision: 282872
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=282872&view=rev
> > Log:
> > CVP. Turn marking adds as no wrap on by default (was turned off by
> 279082)
> >
> > With 282650 in tree extra no wrap on adds doesn't cause regressions
> anymore. Reenable the optimzation.
> >
> > Modified:
> >     llvm/trunk/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
> >
> > Modified: llvm/trunk/lib/Transforms/Scalar/
> CorrelatedValuePropagation.cpp
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> Transforms/Scalar/CorrelatedValuePropagation.cpp?rev=282872&r1=282871&r2=
> 282872&view=diff
> > ============================================================
> ==================
> > --- llvm/trunk/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
> (original)
> > +++ llvm/trunk/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp Fri
> Sep 30 11:20:08 2016
> > @@ -40,7 +40,7 @@ STATISTIC(NumDeadCases, "Number of switc
> >  STATISTIC(NumSDivs,     "Number of sdiv converted to udiv");
> >  STATISTIC(NumSRems,     "Number of srem converted to urem");
> >
> > -static cl::opt<bool> DontProcessAdds("cvp-dont-process-adds",
> cl::init(true));
> > +static cl::opt<bool> DontProcessAdds("cvp-dont-process-adds",
> cl::init(false));
> >
> >  namespace {
> >    class CorrelatedValuePropagation : public FunctionPass {
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180501/fa51c928/attachment.html>


More information about the llvm-commits mailing list