<div dir="ltr">Did any of this ever get resolved?<div>This code has been sitting around unused for over a year now.</div><div><br></div><div>(I was looking at CVP and trying to understand why it has an uncommented, not-understandable parameter called "dontprocessadds")</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 23, 2017 at 2:41 PM, Hans Wennborg via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This was reverted in r296030 due to PR31181.<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Sep 30, 2016 at 9:20 AM, Artur Pilipenko via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: apilipenko<br>
> Date: Fri Sep 30 11:20:08 2016<br>
> New Revision: 282872<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282872&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=282872&view=rev</a><br>
> Log:<br>
> CVP. Turn marking adds as no wrap on by default (was turned off by 279082)<br>
><br>
> With 282650 in tree extra no wrap on adds doesn't cause regressions anymore. Reenable the optimzation.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>CorrelatedValuePropagation.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>CorrelatedValuePropagation.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp?rev=282872&r1=282871&r2=282872&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/<wbr>CorrelatedValuePropagation.<wbr>cpp?rev=282872&r1=282871&r2=<wbr>282872&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>CorrelatedValuePropagation.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>CorrelatedValuePropagation.cpp Fri Sep 30 11:20:08 2016<br>
> @@ -40,7 +40,7 @@ STATISTIC(NumDeadCases, "Number of switc<br>
>  STATISTIC(NumSDivs,     "Number of sdiv converted to udiv");<br>
>  STATISTIC(NumSRems,     "Number of srem converted to urem");<br>
><br>
> -static cl::opt<bool> DontProcessAdds("cvp-dont-<wbr>process-adds", cl::init(true));<br>
> +static cl::opt<bool> DontProcessAdds("cvp-dont-<wbr>process-adds", cl::init(false));<br>
><br>
>  namespace {<br>
>    class CorrelatedValuePropagation : public FunctionPass {<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>