[PATCH] D46177: [llvm-objcopy] Add --globalize-symbol option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

Sure, I will wait for them to review too ! Thanks for reviewing btw :)



================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:138
+static auto contains(const C &Container, const T &X)
+    -> decltype(std::end(Container), true) {
+  return std::end(Container) !=
----------------
alexshap wrote:
> maybe i'm missing smth - but why not simply return bool ?
This line is here to ensure we are passing the function a container. Otherwise, it throws an error at CT.
This is a trick I've seen once, but maybe it's not a good practice ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46177