[PATCH] D46177: [llvm-objcopy] Add --globalize-symbol option

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 09:13:46 PDT 2018


alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.

added one more inline comment, otherwise, to me this looks good, but i would wait for Jake and James



================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:138
+static auto contains(const C &Container, const T &X)
+    -> decltype(std::end(Container), true) {
+  return std::end(Container) !=
----------------
maybe i'm missing smth - but why not simply return bool ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46177





More information about the llvm-commits mailing list