[PATCH] D46047: [SCEV] Introduce bulk umin creation utilities

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 18:23:35 PDT 2018


mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:3967
+const SCEV *ScalarEvolution::getUMinFromMismatchedTypes(
+    SmallVectorImpl<const SCEV *> &Ops) {
+  // Find the max type first.
----------------
mkazantsev wrote:
> Maybe add a fast path for Ops.size() == 1? I'm OK if it goes as a separate NFC.
Also please assert on Ops.empty()


https://reviews.llvm.org/D46047





More information about the llvm-commits mailing list