[PATCH] D46047: [SCEV] Introduce bulk umin creation utilities

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 18:21:31 PDT 2018


mkazantsev accepted this revision.
mkazantsev added a comment.

LGTM too. The same should be done for max.



================
Comment at: lib/Analysis/ScalarEvolution.cpp:3967
+const SCEV *ScalarEvolution::getUMinFromMismatchedTypes(
+    SmallVectorImpl<const SCEV *> &Ops) {
+  // Find the max type first.
----------------
Maybe add a fast path for Ops.size() == 1? I'm OK if it goes as a separate NFC.


https://reviews.llvm.org/D46047





More information about the llvm-commits mailing list