[PATCH] D45916: Enable MachineOutliner by default under -Oz for AArch64

[Jessica Paquette via Phabricator via llvm-commits]

paquette marked an inline comment as done.
paquette added inline comments.


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:120
+    cl::init(false),
+    cl::desc("Disable machine outliner"));
 // Enable or disable FastISel. Both options are needed, because
----------------
efriedma wrote:
> Instead of having two flags, can you just check getNumOccurrences()?
"enable-machine-outliner" implies "run it on everything, even things the target doesn't want by default". This isn't actually symmetric with "disable-machine-outliner", which says "don't run it on anything at all". I think "enable-machine-outliner" should be renamed to something that better describes the intended behaviour. I'll do that in a follow-up patch.


https://reviews.llvm.org/D45916