[PATCH] D45916: Enable MachineOutliner by default under -Oz for AArch64

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 10:43:32 PDT 2018


paquette updated this revision to Diff 144158.
paquette added a comment.

Updated diff to reflect review comments and discussion on the RFC. In the RFC, we decided that it'd be better to base the decision to outline off of function attributes for compatibility with LTO and extensibility of the outliner. This is a far less invasive change, and means that every patch other than this can be abandoned.

I also added a comment on the "-enable-machine-outliner" flag saying what it's *actually* supposed to mean after the application of this patch. In a follow-up patch, we should change this flag to something that better implies what the flag actually does. The only reason I didn't do that here is that I'd have to update every test in *this* patch which is a little too much noise for review.


https://reviews.llvm.org/D45916

Files:
  include/llvm/CodeGen/TargetInstrInfo.h
  lib/CodeGen/MachineOutliner.cpp
  lib/CodeGen/TargetPassConfig.cpp
  lib/Target/AArch64/AArch64InstrInfo.cpp
  lib/Target/AArch64/AArch64InstrInfo.h
  test/CodeGen/AArch64/machine-outliner-calls.mir
  test/CodeGen/AArch64/machine-outliner-flags.ll
  test/CodeGen/AArch64/machine-outliner.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45916.144158.patch
Type: text/x-patch
Size: 6276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180426/67e3eb28/attachment.bin>


More information about the llvm-commits mailing list