[PATCH] D46080: Pack symbols a bit more

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 14:32:07 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D46080#1078640, @ruiu wrote:

> Maybe we should remove StringRefZ class and use a char pointer instead? The point of having StringRefZ class is that an instance of StringRefZ is automatically converted to StringRefZ when needed, but I think we no longer use the feature after this patch.


It is still convenient for the constructor argument. In some cases we know the size. Without it we have to overload the constructor so that there is a variant with "const char*" and one with StringRef.


https://reviews.llvm.org/D46080





More information about the llvm-commits mailing list