[PATCH] D46080: Pack symbols a bit more
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Apr 25 14:00:58 PDT 2018
    
    
  
ruiu added a comment.
Maybe we should remove StringRefZ class and use a char pointer instead? The point of having StringRefZ class is that an instance of StringRefZ is automatically converted to StringRefZ when needed, but I think we no longer use the feature after this patch.
================
Comment at: ELF/Symbols.h:53
+  const char *NameStart;
+  mutable unsigned NameSize;
+
----------------
uint32_t is probably better even though they are likely the same.
https://reviews.llvm.org/D46080
    
    
More information about the llvm-commits
mailing list