[PATCH] D45930: [Support] Upstream anonymization and manipulating of BCSymbolMaps

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

Thanks for working on this Jonas. Duncan and Adrian has already covered pretty much all I want to say. A small additional comments.



================
Comment at: llvm/include/llvm/Support/Anonymization.h:56
+  /// Derived classes may wish to use a different format.
+  void readReverseMap(MemoryBuffer *buf) { readReverseMapImpl(buf); }
+
----------------
With the current LLVM infrastructure, it would be good to return Error to deal with the incompatible format.


================
Comment at: llvm/unittests/Support/AnonymizationTest.cpp:14
+using namespace llvm;
+
+TEST(AnonymizationTest, anonymizeSimple) {
----------------
It would be good to test looking up index doesn't exist or serialization of the reverse map as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D45930