[PATCH] D45930: [Support] Upstream anonymization and manipulating of BCSymbolMaps

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/Support/Anonymization.h:41
+  /// Anonymize a string, remember in the reverseMap if reverse is true.
+  /// Keep 'l' or 'L' prefix when keepPrefix is true.
+  StringRef anonymize(StringRef Src, bool reverse = false,
----------------
cann you add an anonymous `enum { keepPrefix = true; };`


================
Comment at: llvm/include/llvm/Support/Anonymization.h:45
+
+  /// Revese lookup a string in the map.
+  Expected<StringRef> lookup(StringRef Str) const { return lookupImpl(Str); }
----------------
Reverse


================
Comment at: llvm/include/llvm/Support/Anonymization.h:58
+
+  // Access the allocator.
+  BumpPtrAllocator &getAllocator() { return Alloc; }
----------------
dexonsmith wrote:
> Not sure this comment adds any value.
///


Repository:
  rL LLVM

https://reviews.llvm.org/D45930