[PATCH] D35209: [ARM] Unify handling of M-Class system registers

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 23 06:25:57 PDT 2018


thakis added a comment.
Herald added a subscriber: chrib.

Sorry about the belated review comment, but:



================
Comment at: llvm/trunk/lib/Target/ARM/Utils/ARMBaseInfo.h:23
+#include "llvm/MC/SubtargetFeature.h"
+#include "MCTargetDesc/ARMMCTargetDesc.h"
+
----------------
This line means that Utils depends on MCTargetDesc. But MCTargetDesc depends on InstPrinter, which depends on Util. So this gives us a logical dependency cycle. Can you fix this?


Repository:
  rL LLVM

https://reviews.llvm.org/D35209





More information about the llvm-commits mailing list