[PATCH] D45563: [X86][AArch64][NFC] Add tests for masked merge unfolding

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 21 07:07:10 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D45563#1074387, @lebedev.ri wrote:

> In https://reviews.llvm.org/D45563#1074051, @spatel wrote:
>
> > LGTM. You could increase diversity in the constant mask tests by not using a single-string-of-set-bits constant (eg 0x0f0f0f0f instead of 0x0000ffff).
>
>
> But since we don't do anything (not fold, not unfold) with these patterns
>  with constant masks, is there any point in adding even more tests?


I wouldn't add more tests, but different constants might show the variety of codegen options that AArch is using on these sequences (x86 probably has no differences in that respect?).


Repository:
  rL LLVM

https://reviews.llvm.org/D45563





More information about the llvm-commits mailing list