[PATCH] D45563: [X86][AArch64][NFC] Add tests for masked merge unfolding

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 21 02:11:40 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D45563#1074051, @spatel wrote:

> LGTM. You could increase diversity in the constant mask tests by not using a single-string-of-set-bits constant (eg 0x0f0f0f0f instead of 0x0000ffff).


But since we don't do anything (not fold, not unfold) with these patterns
with constant masks, is there any point in adding even more tests?


Repository:
  rL LLVM

https://reviews.llvm.org/D45563





More information about the llvm-commits mailing list