[PATCH] D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 06:42:27 PDT 2018


sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp:972
 
-void AArch64InstPrinter::printMemExtend(const MCInst *MI, unsigned OpNum,
-                                        raw_ostream &O, char SrcRegKind,
-                                        unsigned Width) {
-  unsigned SignExtend = MI->getOperand(OpNum).getImm();
-  unsigned DoShift = MI->getOperand(OpNum + 1).getImm();
-
+static void printMemExtendImpl(unsigned SignExtend, unsigned DoShift,
+                               unsigned Width, char SrcRegKind,
----------------
SjoerdMeijer wrote:
> Nit: SignExtend and DoShift can be booleans?
Yes they can! I will change that before I commit, thanks for pointing out!


https://reviews.llvm.org/D45689





More information about the llvm-commits mailing list