[PATCH] D45308: [IPRA] Do not collect register usage information on functions that can be derefined

Vivek Pandya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 10:46:17 PDT 2018


vivekvpandya added a comment.

Change looks good to me. But please fix the new test case as suggested by @nemanjai 
In this new test do you see improvement in register allocation due to IPRA? If test-case does not show any benefit due to IPRA then it is not suitable test for this patch.
Also I hope this patch is also tested with other architecture which have LIT based test-cases for IPRA. It is very unlikely that such test-case will have function with linkage type which return true for isInterposableLinkage() but if such case is there then this change may break such tests.


https://reviews.llvm.org/D45308





More information about the llvm-commits mailing list