[PATCH] D45308: [IPRA] Do not collect register usage information on functions that can be derefined

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 05:58:43 PDT 2018


nemanjai added a comment.

This seems perfectly fine. Maybe the test case can be slightly improved. Adding the originator of this code to the review.



================
Comment at: llvm/test/CodeGen/PowerPC/ipra-odr.ll:1
+; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu -enable-ipra < %s | FileCheck %s
+;
----------------
Can we make the checks stronger with `-print-regusage`?


================
Comment at: llvm/test/CodeGen/PowerPC/ipra-odr.ll:11
+entry:
+b  %add = add nsw i64 %b, %a
+  store i64 %add, i64* @x, align 4
----------------
I imagine this stray `b` character will cause test case failures.


https://reviews.llvm.org/D45308





More information about the llvm-commits mailing list