[PATCH] D45389: [Power9]Legalize and emit code for converting (Un)Signed Word to Quad-Precision

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: test/CodeGen/PowerPC/f128-conv.ll:167
+; CHECK-LABEL: swConv2qp_02
+; CHECK-NOT: ld
+; CHECK: lxsiwax [[REG:[0-9]+]], 0, 4
----------------
nemanjai wrote:
> Is this supposed to be `CHECK-NOT: lwz`?
yes.


================
Comment at: test/CodeGen/PowerPC/f128-conv.ll:186
+; CHECK: ld [[REG]], .LC2 at toc@l([[REG]])
+; CHECK: lxsiwax [[REG0:[0-9]+]], 0, [[REG]]
+; CHECK-NEXT: xscvsdqp [[CONV:[0-9]+]], [[REG0]]
----------------
nemanjai wrote:
> This seems weird. Where is the offset from the start of the array calculated?
missing `addi`
Will update to:
```
; CHECK: addi [[REG2:[0-9]+]], [[REG]], 12
; CHECK: lxsiwax [[REG0:[0-9]+]], 0, [[REG2]]
```


https://reviews.llvm.org/D45389